test: cover poster page tiling calculations - #48
Merged
McanKul merged 1 commit intoAug 17, 2026
Conversation
McanKul
approved these changes
Aug 17, 2026
McanKul
left a comment
McanKul
left a comment
Owner
There was a problem hiding this comment.
Thanks again, Dan — this is a focused and thorough second contribution. The boundary, overlap, orientation, and size-label cases all look good; I also verified the targeted tests, full frontend suite, typecheck, and production build locally. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No production code was changed; the existing helpers satisfy the specified behavior.
Verification
npm test -- src/lib/paper.test.ts— 14 tests passednpm run typecheck— passedCloses #18